Story Quality Gate

D5.0

Two-pass Story review that fails fast, creates needed fix/refactor/test tasks, and finalizes the Story only after tests are verified.

intermediateCoding & Developmentcodingclaude-skill
Get This Skill on GitHub

Overview


name: ln-500-story-quality-gate description: Story-level quality orchestrator. Pass 1: code quality -> regression -> manual testing (fail fast). Pass 2: verify tests/coverage -> mark Story Done. Auto-discovers team/config.

Story Quality Gate

Two-pass Story review that fails fast, creates needed fix/refactor/test tasks, and finalizes the Story only after tests are verified.

Purpose & Scope

  • Pass 1 (after impl tasks Done): run code-quality, lint, regression, and manual testing; if all pass, create/confirm test task; otherwise create targeted fix/refactor tasks and stop.
  • Pass 2 (after test task Done): verify tests/coverage/priority limits and close Story to Done or create fix tasks.
  • Delegates work to 341/342/343 workers and ln-510-test-planner; invoked by ln-400-story-executor.

When to Use

  • Pass 1: all implementation tasks Done; test task missing or not Done.
  • Pass 2: test task exists and is Done.
  • Explicit pass parameter can force 1 or 2; otherwise auto-detect by test task status.

Workflow (concise)

  • Phase 1 Discovery: Auto-discover team/config; select Story; load Story + task metadata (no descriptions), detect test task status.
  • Pass 1 flow (fail fast):
    1. Invoke ln-501-code-quality-checker. If issues -> create refactor task (Backlog), stop.
    2. Run all linters from tech_stack.md. If fail -> create lint-fix task, stop.
    3. Invoke ln-502-regression-checker. If fail -> create regression-fix task, stop.
    4. Invoke ln-510-test-planner (orchestrates: ln-511-test-researcher → ln-512-manual-tester → ln-513-auto-test-planner). If manual testing fails -> create bug-fix task, stop. If all passed -> test task created/updated.
    5. If test task exists and Done, jump to Pass 2; if exists but not Done, report status and stop.
  • Pass 2 flow (after test task Done):
    1. Load Story/test task; read test plan/results and manual testing comment from Pass 1.
    2. Verify limits and priority: Priority ≤15; E2E 2-5, Integration 0-8, Unit 0-15, total 10-28; tests focus on business logic (no framework/DB/library tests).
    3. Ensure Priority ≤15 scenarios and Story AC are covered by tests; infra/docs updates present.
    4. If pass -> mark Story Done in Linear; minimal kanban cleanup if needed. If fail -> create fix tasks (Backlog) and stop; ln-400 will loop.

TodoWrite format (mandatory): Add pass steps to todos before starting:

Pass 1:
- Invoke ln-501-code-quality-checker (in_progress)
- Run linters from tech_stack.md (pending)
- Invoke ln-502-regression-checker (pending)
- Invoke ln-510-test-planner (research + manual + auto tests) (pending)

Pass 2:
- Verify test task coverage (in_progress)
- Mark Story Done (pending)

Mark each as in_progress when starting, completed when done. On failure, mark remaining as skipped.

Worker Invocation (MANDATORY)

CRITICAL: All worker delegations MUST use Skill tool. DO NOT run linters/tests directly.

StepWorkerHow to Invoke
Code Qualityln-501-code-quality-checkerSkill(skill: "ln-501-code-quality-checker")
Regressionln-502-regression-checkerSkill(skill: "ln-502-regression-checker")
Test Planningln-510-test-plannerSkill(skill: "ln-510-test-planner")

Note: ln-510 orchestrates the full test pipeline (ln-511 research → ln-512 manual → ln-513 auto tests).

❌ FORBIDDEN SHORTCUTS (Anti-Patterns):

  • Running mypy, ruff, pytest directly instead of invoking ln-501/ln-502
  • Doing "minimal quality check" (just linters) and skipping ln-510 test planning
  • Asking user "Want me to run the full skill?" after doing partial checks
  • Marking steps as "completed" in todo without invoking the actual skill
  • Any command execution that should be delegated to a worker skill

✅ CORRECT BEHAVIOR:

  • Use Skill(skill: "ln-50X-...") for EVERY step — NO EXCEPTIONS
  • Wait for each skill to complete before proceeding
  • If skill fails → create fix task → STOP (fail fast)
  • Never bypass skills with "I'll just run the command myself"

ZERO TOLERANCE: If you find yourself running quality commands directly (mypy, ruff, pytest, curl) instead of invoking the appropriate skill, STOP and use Skill tool instead.

Critical Rules

  • Early-exit: any failure creates a specific task and stops Pass 1/2.
  • Single source of truth: rely on Linear metadata for tasks; kanban is updated by workers/ln-400.
  • Task creation via skills only (ln-510/ln-301); this skill never edits tasks directly.
  • Pass 2 only runs when test task is Done; otherwise return error/status.
  • Language preservation in comments (EN/RU).

Definition of Done

  • Pass 1: ln-501 pass OR refactor task created; linters pass OR lint-fix task created; ln-502 pass OR regression-fix task created; ln-510 pipeline pass (research + manual + auto tests) OR bug-fix task created; test task created/updated; exits.
  • Pass 2: test task verified (priority/limits/coverage/infra/docs); Story set to Done in Linear (if pass) or fix tasks created (if fail); kanban minimally cleaned if needed.
  • Summary/comment posted in Linear for actions taken.

Reference Files

  • Workers: ../ln-501-code-quality-checker/SKILL.md, ../ln-502-regression-checker/SKILL.md
  • Test planning orchestrator: ../ln-510-test-planner/SKILL.md (coordinates ln-511/512/513)
  • Tech stack/linters: docs/project/tech_stack.md

Version: 4.0.0 (Simplified Pass 1: ln-510 now orchestrates full test pipeline - research/manual/auto) Last Updated: 2026-01-15

What This Skill Can Do

AI-generated examples showing real capabilities

Ready to use this skill?

Visit the original repository to get the full skill configuration and installation instructions.

View on GitHub

Related Skills